Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Symfony 5.4 #40518

Merged
merged 1 commit into from
May 21, 2023
Merged

[full-ci] Symfony 5.4 #40518

merged 1 commit into from
May 21, 2023

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Nov 29, 2022 •
edited
Loading

Description

Code and tests have already been updated so that they work with the existing Symfony 4.4 and also work with Symfony 5.4.
See the related issue for links to those PRs.

IMO this is ready for merge to core.

Note: if we merge this, then it will end up in the 10.13 release. We will have to also release any apps that need code changes. Those will be found by nightly CI running with core master having Symfony 5. Apps can have code made compatible with both Symfony 4 and 5, so any effected apps can be released separately prior to 10.13 and will still work with older 10.* releases that have Symfony 4.

There will be some effort needed to sort out and release the apps.

Related Issue

#39630

Motivation and Context

Symfony 4 support is heading to the end.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Nov 29, 2022
@phil-davis phil-davis force-pushed the symfony-5.4 branch 3 times, most recently from bb1ab08 to 0104b0c Compare January 13, 2023 08:49
@phil-davis phil-davis mentioned this pull request Jan 13, 2023
Merged
11 tasks
@phil-davis phil-davis changed the title Symfony 5.4 [full-ci] Symfony 5.4 Jan 14, 2023
@phil-davis phil-davis force-pushed the symfony-5.4 branch 3 times, most recently from fa8b5a1 to dd03b18 Compare May 18, 2023 06:32
@owncloud owncloud deleted a comment from ownclouders May 18, 2023
@phil-davis phil-davis requested a review from jvillafanez May 19, 2023 06:46
@phil-davis phil-davis marked this pull request as ready for review May 19, 2023 06:46
@phil-davis phil-davis removed the request for review from jvillafanez May 19, 2023 06:46
@phil-davis phil-davis marked this pull request as draft May 19, 2023 06:46
@phil-davis phil-davis marked this pull request as ready for review May 19, 2023 10:36
@phil-davis
Copy link
Contributor Author

Note: needs discussion about when we actually do this - now for 10.13, or later in the year.
Symfony 4.4 security support ends in November 2023.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pako81
Copy link

pako81 commented May 19, 2023

We should probably try to get this into 10.13.0. I don't think we will able to release an other major version before November 2023.

@phil-davis
Copy link
Contributor Author

We should probably try to get this into 10.13.0. I don't think we will able to release an other major version before November 2023.

Sounds reasonable. I don't think that there will be much work in adjusting app code - the few things that had to be changed in core are known, so I can look for those in apps easily. The main effort will "just" be going through the process of QA and release for new versions of quite a few apps (might be 10 or 15 to do).

@phil-davis
Copy link
Contributor Author

Merging - we will get nightly CI from all the apps overnight and can sort out which apps also need touching.

@phil-davis phil-davis merged commit 1c1ab2f into master May 21, 2023
@delete-merged-branch delete-merged-branch bot deleted the symfony-5.4 branch May 21, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pako81 pako81 pako81 approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@jnweiger jnweiger Awaiting requested review from jnweiger

Assignees

@phil-davis phil-davis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @pako81